Bugfix: Simplify login and startMailVerify functions, improve error handling and validation

src/actions/auth/login/index.ts

@@ -1,34 +1,13 @@
 import jwt from "jsonwebtoken";
-import {
-    plainToInstance
-} from "class-transformer";
-import {
-    validate
-} from "class-validator";
 import {
     User
 } from "../../../models/User";
 import {
-    LoginResult,
-    LoginInput
+    LoginResult, LoginInput
 } from "./types";
 import redis from "../../../config/redis";
-import {
-    formatValidationErrors
-} from "../../../utils";
 
 const login = async (input: LoginInput): Promise<LoginResult> => {
-    const dto = plainToInstance(LoginInput, input);
-    const errors = await validate(dto);
-
-    if (errors.length > 0) {
-        const formattedErrors = formatValidationErrors(errors);
-        return {
-            code: 400,
-            message: formattedErrors[0],
-        };
-    }
-
     const {
         password,
         mail

src/actions/auth/startMailVerify/index.ts

@@ -3,12 +3,10 @@ import {
 } from "../../../models/User";
 import redis from "../../../config/redis";
 import {
-    StartMailVerifyResult,
-    StartMailVerifyInput
+    StartMailVerifyResult, StartMailVerifyInput
 } from "./types";
 import {
-    verificationCode,
-    TTL_SECONDS
+    verificationCode, TTL_SECONDS
 } from "../../../utils";
 // import { sendMail } from "../../../utils/mailer"; // mail gönderme fonskiyonu bu şekilde ilerde import edilecek.
 
@@ -18,13 +16,6 @@ const startMailVerify = async (input: StartMailVerifyInput): Promise<StartMailVe
             userID
         } = input;
 
-        if (!userID) {
-            return {
-                message: "userID-required",
-                code: 400,
-            };
-        }
-
         const user = await User.findById(userID);
         if (!user) {
             return {

src/actions/auth/startMailVerify/types.ts

@@ -1,5 +1,11 @@
-export interface StartMailVerifyInput {
-    userID: string;
+import {
+    IsNotEmpty, IsString
+} from "class-validator";
+
+export class StartMailVerifyInput {
+    @IsString({ message: "userID must be a string" })
+    @IsNotEmpty({ message: "userID is required" })
+    userID!: string;
 }
 
 export interface StartMailVerifyResult {

src/controllers/authController.ts

@@ -17,7 +17,7 @@ import {
 
 export const register = async (req: Request, res: Response): Promise<void> => {
     const result = await _register(req.body);
-    
+
     res.status(result.code)
         .json({
             message: result.message,
@@ -27,15 +27,7 @@ export const register = async (req: Request, res: Response): Promise<void> => {
 
 export const login = async (req: Request, res: Response): Promise<void> => {
     try {
-        const {
-            password,
-            mail
-        } = req.body;
-
-        const result = await _login({
-            password,
-            mail
-        });
+        const result = await _login(req.body);
 
         res.status(result.code).json({
             message: result.message,
@@ -46,12 +38,11 @@ export const login = async (req: Request, res: Response): Promise<void> => {
         });
 
     } catch (error) {
-        console.error("Login error:", error);
-        res.status(500)
-            .json({
-                message: "server-error",
-                code: 500,
-            });
+        console.error("Login controller error:", error);
+        res.status(500).json({
+            message: "server-error",
+            code: 500,
+        });
     }
 };
 
@@ -104,15 +95,27 @@ export const refreshToken = async (req: Request, res: Response): Promise<void> =
         });
 };
 
-export const startMailVerify = async (req: Request, res: Response): Promise<void> => {
+export const validateToken = async (req: AuthRequest, res: Response): Promise<void> => {
     try {
-        const {
-            userID
-        } = req.body;
-
-        const result = await _startMailVerify({
-            userID
+        res.status(200).json({
+            message: "token-valid",
+            code: 200,
+            payload: {
+                user: req.context
+            }
+        });
+    } catch (error) {
+        console.error("Validate token error:", error);
+        res.status(500).json({
+            message: "server-error",
+            code: 500
         });
+    }
+};
+
+export const startMailVerify = async (req: Request, res: Response): Promise<void> => {
+    try {
+        const result = await _startMailVerify(req.body);
 
         res.status(result.code).json({
             message: result.message,

src/routes/authRoutes.ts

@@ -4,6 +4,7 @@ import {
 import {
     finishMailVerify,
     startMailVerify,
+    validateToken,
     refreshToken,
     register,
     logout,
@@ -12,13 +13,13 @@ import {
 } from "../controllers/authController";
 import {
     authMiddleware,
-    AuthRequest
 } from "../middlewares/authMiddleware";
 import {
-    validateBody 
+    validateBody
 } from "../middlewares/validateBody";
 import {
     FinishMailVerifyInput,
+    StartMailVerifyInput,
     RefreshTokenInput,
     RegisterInput,
     LoginInput
@@ -27,20 +28,13 @@ import {
 const router = Router();
 
 router.post("/finish-mail-verify", validateBody(FinishMailVerifyInput), finishMailVerify);
+router.post("/start-mail-verify", validateBody(StartMailVerifyInput), startMailVerify);
 router.post("/refresh-token", validateBody(RefreshTokenInput), refreshToken);
 router.post("/register", validateBody(RegisterInput), register);
 router.post("/login", validateBody(LoginInput), login);
-router.post("/start-mail-verify", startMailVerify);
 router.post("/logout", authMiddleware, logout);
-router.get("/me", authMiddleware, me);
 
-router.get("/validate-token", authMiddleware, (req: AuthRequest, res) => {
-    res.status(200)
-        .json({
-            message: "token-valid",
-            context: req.context,
-            code: 200
-        });
-});
+router.get("/validate-token", authMiddleware, validateToken);
+router.get("/me", authMiddleware, me);
 
 export default router;